On Fri, 27 Sep 2024 07:43:06 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments updated
>
> test/jdk/java/awt/Dialog/DialogResizeTest.java line 133:
>
>> 131: public void componentHidden(ComponentEvent e) {
>> 132: System.out.println("componentHidden event occurred.");
>> 133: }
>
> I guess PassFailJFrame.log would be of more use than System println, if at
> all these logs are of any help..
I'm getting this error if I use ` PassFailJFrame.log` to `componentResize`
method.
`java.lang.NullPointerException: Cannot invoke
"javax.swing.JTextArea.append(String)" because "PassFailJFrame.logArea" is
null`. Since the test is about resize, I've updated only resize related print
statement.
> test/jdk/java/awt/Dialog/FileDialogWrongNameCrash.java line 58:
>
>> 56:
>> 57: private static Frame initialize() {
>> 58: Frame frame = new Frame("Frame");
>
> give more meaningful name
Updated.
> test/jdk/java/awt/Dialog/GetLocationTest_1.java line 50:
>
>> 48: up with the top left by the cursor
>> 49: 2. If you see this correct behavior press PASS. If you
>> see that
>> 50: the yellow window is offset by an inset (5, 24) press
>> FAIL
>
> how will tester knows that the inset is of this dimension, it might vary from
> platform to platform and also vary with different scaling? maybe just delete
> this hardcoded dimension?
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778369974
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778370100
PR Review Comment: https://git.openjdk.org/jdk/pull/21174#discussion_r1778370296
