Re: RFR: 8340799: Add border inside instruction frame in PassFailJFrame

[Alexey Ivanov]

On Thu, 3 Oct 2024 15:05:50 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

> This changeset unifies borders used inside the `PassFailJFrame` framework and 
> adds missing borders.
> 
> I started it in ![21038](https://git.openjdk.org/jdk/pull/21038) for 
> [JDK-8340306](https://bugs.openjdk.org/browse/JDK-8340306). That changeset 
> handled only the instructions.
> 
> This changeset add a border around the entire contents of the instruction 
> frame, adds a border to the log area as well as to the failure reason dialog. 
> The result looks more pleasing and consistent.
> 
> I chose the gap of 4 because it plays nicely with fractional scales: 4 × 1.25 
> = 5 — no fractional pixels.

test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 672:

> 670:         JPanel textPanel = new JPanel(new BorderLayout());
> 671:         textPanel.setBorder(createEmptyBorder(GAP, 0, GAP, 0));
> 672:         textPanel.add(new JScrollPane(text), BorderLayout.CENTER);

I accidentally committed these three lines in 
![21162](https://git.openjdk.org/jdk/pull/21162) for 
[JDK-8340785](https://bugs.openjdk.org/browse/JDK-8340785) and I didn't notice 
it.

This three-line snippet was completely unrelated to updating description of the 
`PassFailJFrame` class and samples.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21327#discussion_r1786409675