On Thu, 3 Oct 2024 15:05:50 GMT, Alexey Ivanov <[email protected]> wrote:

> This changeset unifies borders used inside the `PassFailJFrame` framework and 
> adds missing borders.
> 
> I started it in ![21038](https://git.openjdk.org/jdk/pull/21038) for 
> [JDK-8340306](https://bugs.openjdk.org/browse/JDK-8340306). That changeset 
> handled only the instructions.
> 
> This changeset add a border around the entire contents of the instruction 
> frame, adds a border to the log area as well as to the failure reason dialog. 
> The result looks more pleasing and consistent.
> 
> I chose the gap of 4 because it plays nicely with fractional scales: 4 × 1.25 
> = 5 — no fractional pixels.

A couple of screenshots for comparison.

**Before:**  
![Screenshot of PrintLatinCJKTest where no borders are added to 
`PassFailJFrame` instruction 
UI](https://github.com/user-attachments/assets/33d309a9-5904-40f6-803c-cb1161bca1a1)

**After:**  
![Screenshot of PrintLatinCJKTest with added borders in `PassFailJFrame` 
instruction 
UI](https://github.com/user-attachments/assets/d955e717-8d48-479d-9713-f2848e56ac2c)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21327#issuecomment-2391769964

Reply via email to