On Mon, 14 Oct 2024 15:34:29 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> The test `javax/swing/JButton/bug4323121.java` contains lots of unused >> methods. >> >> I removed all the unused methods by extending `MouseAdapter`. >> >> I use `CountDownLatch` to synchronise actions in the test. >> >> The test still verifies `button.getModel().isArmed()` doesn't always return >> `true` for classes which extend `JButton`. I verified the updated test fails >> in 1.3.0 and passes in 1.4.0, so the test still reproduces the original >> problem. > > Alexey Ivanov has updated the pull request incrementally with two additional > commits since the last revision: > > - Clarify thread-safety of the modelArmed flag > - Remove MouseMotionListener; get rid of eventHandler variable Test looks good still. Changes made do clean up the look of the test's code a lot. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/21475#pullrequestreview-2370682916
