On Fri, 18 Oct 2024 12:19:24 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> The test `javax/swing/JButton/bug4323121.java` contains lots of unused >> methods. >> >> I removed all the unused methods by extending `MouseAdapter`. >> >> I use `CountDownLatch` to synchronise actions in the test. >> >> The test still verifies `button.getModel().isArmed()` doesn't always return >> `true` for classes which extend `JButton`. I verified the updated test fails >> in 1.3.0 and passes in 1.4.0, so the test still reproduces the original >> problem. > > Alexey Ivanov has updated the pull request incrementally with one additional > commit since the last revision: > > Remove space before comma > > Co-authored-by: Abhishek Kumar <abhishek.cx.ku...@oracle.com> test/jdk/javax/swing/JButton/bug4323121.java line 66: > 64: }); > 65: robot.waitForIdle(); > 66: robot.delay(1000); The new code probably should follow the same pattern, flush all events/commands to native by the waitForIdle. and then wait response from OS for 1_or_less second. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21475#discussion_r1806763932
