On Tue, 5 Nov 2024 18:27:22 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Daniel Gredler has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Separate paint logic from test class > > test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 232: > >> 230: } >> 231: >> 232: // The test needs a physical font that supports Latin. > > The `getPhysicalFont` could be updated so that its `switch` statement uses > `Font.` constants, I'm pretty sure that was the intention. It looks like it's trying to be extra resilient by switching on `n.toLowerCase()` (i.e. case-insensitive). Is it OK to make it case-sensitive and use the constants? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1829855797
