On Tue, 5 Nov 2024 19:13:44 GMT, Daniel Gredler <d...@openjdk.org> wrote:
>> There are multiple issue with this test case >> 1) Parser error due to yesno in @run main/manual=yesno >> 2) User can only compare the UI rendering and compare with the print out. >> User can't mark the test as pass or fail due to pass or fail buttons are >> missing. >> 3) When the test is executed using jtreg after user click on the print >> button on the print dialog the whole test UIs ( frames) gets dispose and >> user cannot compare the printout with the UI. But this works as expected in >> test is running individually using java PrintTextTest > > Daniel Gredler has updated the pull request incrementally with one additional > commit since the last revision: > > Use Font constants, addTab(), @Override, final and private modifiers Looks good to me. The only things left are problem-listing and updating the `switch` statement. ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21716#pullrequestreview-2416704791
