On Mon, 11 Nov 2024 07:07:26 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> test/jdk/javax/swing/plaf/nimbus/8041642/bug8041642.java fails in ubuntu 
>> 22.04 OCI with
>> 
>> ----------System.out:(1/30)----------
>> java.awt.Color[r=49,g=0,b=33]
>> ----------System.err:(11/647)----------
>> java.lang.RuntimeException: Bar padding color should be green
>> at bug8041642.main(bug8041642.java:64)
>> at 
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:573)
>> at 
>> com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
>> at java.base/java.lang.Thread.run(Thread.java:1576) 
>> 
>> and the color obtained seems to suggest that the frame is not visible when 
>> the test condition was checked, since the color seems to be dark brown which 
>> seems to be the desktop barkground in ubuntu, I have updated the test to 
>> have more delay of 1sec which is what we used for headful test after 
>> creating GUI and subsequent run works fine in my testing...
>
> Prasanta Sadhukhan has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Save frame BI incase it fails

add frame title, can probably remove the extra "ok" string print on test pass

test/jdk/javax/swing/plaf/nimbus/8041642/bug8041642.java line 65:

> 63:             robot.waitForIdle();
> 64:             robot.delay(1000);
> 65:             SwingUtilities.invokeAndWait(new Runnable() {

remove overhead and replace with lambda function

-------------

PR Review: https://git.openjdk.org/jdk/pull/22002#pullrequestreview-2434487840
PR Review Comment: https://git.openjdk.org/jdk/pull/22002#discussion_r1841196160

Reply via email to