On Mon, 18 Nov 2024 16:56:40 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Save frame BI incase it fails > > test/jdk/javax/swing/plaf/nimbus/8041642/bug8041642.java line 79: > >> 77: Graphics g = img.getGraphics(); >> 78: frame.paint(g); >> 79: g.dispose(); > > On the other hand, it doesn't show what's actually happening on the screen, > so this image may be perfect, but the window may actually be obscured by > something else on the screen. When I ran the full swing tests in those system, this test failed and screen.png shows empty desktop so nothing was there to obscure, it seemed to me frame was made visible programmatically but actually there was some latency to make it visible on screen (since otherwise getLocationOnScreen would have returned ISE), so I added this.. Also, this saved image might also help in finding issue if there is indeed no green color padding ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22002#discussion_r1847719834
