On Fri, 15 Nov 2024 10:26:05 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Since JEP 486 : Permanently Disable the Security Manager >> [https://bugs.openjdk.org/browse/JDK-8338625] is now integrated, calls to >> java.security.AccessController.doPrivileged are obsolete and can be removed. >> >> This PR takes care of some of the shared-platform files in the java.desktop >> module to have them removed. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Remove Suppresswarning src/java.desktop/share/classes/sun/swing/SwingUtilities2.java line 1708: > 1706: return (UIDefaults.LazyValue) (table) -> { > 1707: byte[] buffer = enablePrivileges ? > 1708: getIconBytes(baseClass, rootClass, imageFile) Suggestion: byte[] buffer = getIconBytes(baseClass, rootClass, imageFile); Maybe you could move the method body to `makeIcon(Class<?>, Class<?>, String)` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22133#discussion_r1843554527
