On Fri, 15 Nov 2024 19:50:43 GMT, Phil Race <p...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove Suppresswarning
>
> src/java.desktop/share/classes/sun/awt/image/ImagingLib.java line 91:
>
>> 89: static {
>> 90:
>> 91: System.loadLibrary("mlib_image");
>
> why did you remove the try/catch ? Seems like a semantic change that should
> not be made.
>
> Also this whole class has
> @SuppressWarnings({"removal", "restricted"})
>
> I'm not sure I see anything else that is deprecated for removal, so doesn't
> it need to be updated ?
Other loadLibrary calls in other files in this PR were without try-catch so I
removed it as I thought it redundant..
ANyway, I will revert it back..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22133#discussion_r1845311420
