On Fri, 15 Nov 2024 18:45:11 GMT, Harshitha Onkar <[email protected]> wrote:
> Post JEP-486 (Permanently Disable the Security Manager) cleanup. > Calls to java.security.AccessController.doPrivileged are obsolete thus > removed in this PR. > > This PR addresses removal of AccessController.doPrivileged() calls from > macos-platform files in the java.desktop module.Any SM related imports that > are no longer needed are removed. > > This PR is limited to removing doPrivileged() calls and excludes any > refactoring, reformatting, or other clean up that is out-of-scope for this > fix. > > PS: I have explicitly add comments to the changes where a more watchful > review is required. Marked as reviewed by prr (Reviewer). src/java.desktop/macosx/classes/sun/lwawt/macosx/LWCToolkit.java line 180: > 178: */ > 179: private static final boolean inAWT > 180: = !Boolean.parseBoolean( You could have simplified this to use Boolean.getBoolean() but this is closer to the original so that's fine. ------------- PR Review: https://git.openjdk.org/jdk/pull/22159#pullrequestreview-2439552689 PR Review Comment: https://git.openjdk.org/jdk/pull/22159#discussion_r1844474109
