On Wed, 13 Nov 2024 17:39:38 GMT, Daniel Gredler <d...@openjdk.org> wrote:

>> Daniel Gredler has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Comment tweak ('advance' -> 'translation')
>
> @honkar-jdk This is the followup to PR #21716 discussed last week. Do you 
> have time to review and possibly test on Windows or mac? The change looks 
> good for me on Linux.

@gredler  Tested on windows with print to pdf option. I noticed that the 
"G..y..h..." line is still being printed above instead of below as seen in the 
following screenshot. (Left one - without changes, center window - test window, 
Right one- with the fix). 

If you could attach a similar screenshot of your testing on linux, it would be 
easier to review.

<img width="1403" alt="GlyphPrint" 
src="https://github.com/user-attachments/assets/ce43785e-439b-4d1e-ad48-8fd7101fcb81";>

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2480050258

Reply via email to