On Wed, 20 Nov 2024 18:57:26 GMT, Daniel Gredler <d...@openjdk.org> wrote:
>> @gredler >> >>> Will we need a separate bug in the issue tracker, since this PR will not >>> fix the macOS parts of JDK-8148334? >> >> That's correct. I think it is better to create a new JBS bug and use the new >> JBS ID for this PR than using >> [JDK-8148334](https://bugs.openjdk.org/browse/JDK-8148334). I can create a >> new JBS issue on your behalf. >> Since this test spans across multiple pages testing various glyph >> transformations it is better to keep >> [JDK-8148334](https://bugs.openjdk.org/browse/JDK-8148334) in open state and >> reference it while problemlisting the test. >> >>> I'm not sure whether PRs are allowed to partially fix issues (when they >>> represent more than one bug), or whether they are expected to fully fix >>> whatever issue they reference. >> >> A PR can have fix that focuses on specific issue and separate PRs can be >> created to address other issues. So in this case it seems reasonable to have >> a PR for Windows and Linux fix and create a separate one for macOS. > > @honkar-jdk I just got access to JBS today, so that's not a problem. I've > created JDK-8344637 to track just the Linux and Windows fixes in this PR > (scoping out macOS for now). Have you had a chance to review on Windows? @gredler > Have you had a chance to review on Windows? Yes, following are the screenshots of Page8 on Windows. Both portrait and landscape look good now although I haven't looked at the other pages in detail (to verify the fix works in all cases and does not produce any side-effects/regressions). **Portrait:** <img width="1388" alt="Latest_Pg#8Portrait" src="https://github.com/user-attachments/assets/d6ee00a9-e16d-4405-bc22-9d1f6b09e66b";> **Landscape** <img width="1393" alt="Latest_Pg#8Landscape" src="https://github.com/user-attachments/assets/89dc1734-8ea4-4713-aa1f-c20c892f2734";> ------------- PR Comment: https://git.openjdk.org/jdk/pull/21980#issuecomment-2489348682
