On Thu, 6 Jun 2024 21:35:21 GMT, Alisen Chung <ach...@openjdk.org> wrote:
>> 柳鲲鹏 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains 10 additional commits since the >> last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Update to lastest >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Remove tab >> - Update to latest and make code safer >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - 8264728: When use chinese IME, the candidate box isn't moved with caret >> of JTextArea > > src/java.desktop/unix/classes/sun/awt/X11/XInputMethod.java line 61: > >> 59: } >> 60: >> 61: @Override > > why do these functions need the override tag now? cc @quantum6 I tracked down this PR from your Zhihu answer: https://www.zhihu.com/question/360671800/answer/3481640228 It's your irresponsiveness (towards this question) which lead this PR to be deprecated by the bot, and you blame the OpenJDK community for the atmosphere of laziness? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/13055#discussion_r1846306322