On Fri, 22 Nov 2024 07:05:41 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> 柳鲲鹏 has updated the pull request with a new target base due to a merge or a >> rebase. The incremental webrev excludes the unrelated changes brought in by >> the merge/rebase. The pull request contains 10 additional commits since the >> last revision: >> >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Update to lastest >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - Remove tab >> - Update to latest and make code safer >> - Merge branch 'master' of https://github.com/openjdk/jdk into quantum6 >> - 8264728: When use chinese IME, the candidate box isn't moved with caret >> of JTextArea > > I tested this fix on Ubuntu 22 and 24 with X11 and Wayland and the fix works > except for two minor notes: > 1. With old IM suggestion window it displayed the text we enter in the choose > box as well as in the text area itself interactively which allows easy > editing if you, for example, made a typo - you can use left and right arrows > to navigate within the entered text and fix the typo. With the new style IM > suggestion popup there is no visible cursor in the preview string and while > it is technically possible to navigate with arrows within it to fix typo the > lack of the cursor makes it much harder. > 2. With old IM when you start entering text and dismiss suggestion window > with escape you will still have the text you entered in the text area. For > example for Japanese (Mozc) IM with Hiragana input mode when you start typing > you get hiragana representation in the text area right away and if you press > escape the hiragana string you entered stays in the editor. With your fix no > text appears in editor - only in the IM popup and if you press escape the > text is gone. I do not know if this is intended behavior but it is a change > of behavior and needs to be discussed. > > Also please take time to respond to valid technical requests from > @NikitkoCent and @alisenchung - even though i like the new way of handling IM > more than the old one i would hesitate to approve change that has unresolved > technical questions. @azuev-java, hello! Am I right that you don't mind to accept the following behavior change? > With old IM suggestion window it displayed the text we enter in the choose > box as well as in the text area itself interactively which allows easy > editing if you, for example, made a typo - you can use left and right arrows > to navigate within the entered text and fix the typo. With the new style IM > suggestion popup there is no visible cursor in the preview string and while > it is technically possible to navigate with arrows within it to fix typo the > lack of the cursor makes it much harder. This is exactly what I wrote about in https://github.com/openjdk/jdk/pull/13055#issuecomment-2100900752 and wanted to get feedback about such a change from a project's Reviewer before starting working towards porting JetBrains' version of the patch ------------- PR Comment: https://git.openjdk.org/jdk/pull/13055#issuecomment-2619405368
