On Fri, 15 Nov 2024 06:46:34 GMT, Tejesh R <t...@openjdk.org> wrote:
>> The test is supposed to be problem listed on macos & Linux but the Problem
>> list points to the .java file instead of the .html file.
>> Hence converting
>> java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which
>> would automatically resolve the issue.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Instructions modified for macosx
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line
45:
> 43: 2 scroll-sliders, and 4 scroll-buttons(Not
> applicable for macosx).
> 44: 2. Hover mouse over box-for-text.
> 45: Make sure, that mouse cursor is TextCursor (a.k.a.
> \"beam\").
Suggestion:
Make sure, that mouse cursor is TextCursor (a.k.a.
"beam").
Escape char not necessary.
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line
46:
> 44: 2. Hover mouse over box-for-text.
> 45: Make sure, that mouse cursor is TextCursor (a.k.a.
> \"beam\").
> 46: 3. Hover mouse over each of components (see item 1),
> except for box-for-text.
Some instruction lines overflow due to having not enough columns or the line
being too long. Can either increase the column count or break up the lines
differently. Looks like the lines that end in `box-for-text` and `pressed`
overflow.
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line
50:
> 48: 4. Drag mouse (using any mouse button) from
> box-for-text to every"
> 49: component in item 1, and also outside application
> window."
> 50: Make sure, that cursor remains TextCursor while
> mouse button is pressed.
Suggestion:
4. Drag mouse (using any mouse button) from box-for-text to
every
component in item 1, and also outside application window.
Make sure, that cursor remains TextCursor while mouse
button is pressed.
Remove extra quotes.
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line
52:
> 50: Make sure, that cursor remains TextCursor while
> mouse button is pressed.
> 51: 5. Repeat item 4 for each other component in item 1,
> except for box-for-text
> 52: _but_ now make sure that cursor is DefaultCursor.
Is the underscore around `but` for emphasis? Not sure if needed.
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java line
101:
> 99: return s;
> 100: }
> 101: }
EOF newline
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1846984371
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1846991003
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1846985668
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1846992010
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1846981084
