On Tue, 19 Nov 2024 05:31:06 GMT, Tejesh R <t...@openjdk.org> wrote:

>> test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java 
>> line 46:
>> 
>>> 44:                     2. Hover mouse over box-for-text.
>>> 45:                        Make sure, that mouse cursor is TextCursor 
>>> (a.k.a. \"beam\").
>>> 46:                     3. Hover mouse over each of components (see item 
>>> 1), except for box-for-text.
>> 
>> Some instruction lines overflow due to having not enough columns or the line 
>> being too long. Can either increase the column count or break up the lines 
>> differently. Looks like the lines that end in `box-for-text` and `pressed` 
>> overflow.
>> ![image](https://github.com/user-attachments/assets/72882471-50c1-4d68-b80c-e1e79b52d770)
>
> I have updated column count to handle this scenario. It looks fine in my 
> local machine, not sure how come its overflowing.
> <img width="346" alt="image" 
> src="https://github.com/user-attachments/assets/2a93c2b0-cecd-4cac-8cac-2183870de28f";>

I've encountered similar issues with my tests in the past where it looks fine 
locally. I chalked it up to different OS's, resolutions, text sizes, etc.

Now, I just set column to `40` in my test instructions and follow the standard 
guideline of `80` chars in my IDE to avoid these issues.

>> test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java 
>> line 101:
>> 
>>> 99:         return s;
>>> 100:     }
>>> 101: }
>> 
>> EOF newline
>
> I didn't get?

Usually an empty newline at the end is used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1852599803
PR Review Comment: https://git.openjdk.org/jdk/pull/22026#discussion_r1852600774

Reply via email to