On Tue, 19 Nov 2024 17:37:16 GMT, Phil Race <[email protected]> wrote:
>> Remove doPrivileged calls from javax.imageio, javax.print and some sound
>> impl classes
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8344064
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java line
512:
> 510: private static int GET_IMAGE = 2;
> 511:
> 512: public Object getThemeItem(int type, Object arg) {
I think it's worth to split this huge method into 3. getThemeDir, getUserTheme,
getImage.
Looks like the only reason why it was put into single method - is to have
single `PrivilegedAction` class
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22186#discussion_r1848795636
