On Tue, 26 Nov 2024 17:17:09 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:

>> As a prerequisite for Hermetic Java, we need a statically linked `java` 
>> launcher. It should behave like the normal, dynamically linked `java` 
>> launcher, except that all JDK native libraries should be statically, not 
>> dynamically, linked.
>> 
>> This patch is the first step towards this goal. It will generate a 
>> `static-jdk` image with a statically linked launcher. This launcher is 
>> missing several native libs, however, and does therefore not behave like a 
>> proper dynamic java. One of the reasons for this is that local symbol hiding 
>> in static libraries are not implemented yet, which causes symbol clashes 
>> when linking all static libraries together. This will be addressed in an 
>> upcoming patch. 
>> 
>> All changes in the `src` directory are copied from, or inspired by, changes 
>> made in [the hermetic-java-runtime branch in Project 
>> Leyden](https://github.com/openjdk/leyden/tree/hermetic-java-runtime).
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains 25 commits:
> 
>  - Merge branch 'master' into static-jdk-image
>  - Remove LDFLAGS_STATIC_JDK
>  - Rename EXCLUDE_FROM_STATIC_LIBS to ONLY_EXPORTED, $(MODULE)_JDK_LIBS to 
> $(MODULE)_INCLUDED_LIBS and module-libs.txt to module-included-libs.txt
>  - Find LIBZIP_OBJS automatically
>  - Find LIBJAVA_JPEG_OBJS automatically
>  - Just exclude the a11y libraries from static builds
>  - Copy debuginfo
>  - Restore SetExecname in java_md.c
>  - Fix incremental builds
>  - Merge branch 'master' into static-jdk-image
>  - ... and 15 more: https://git.openjdk.org/jdk/compare/c329f97f...8b1217a8

Hotspot changes look fine.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20837#pullrequestreview-2462695251

Reply via email to