On Mon, 2 Dec 2024 15:10:08 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into static-jdk-image >> - Remove LDFLAGS_STATIC_JDK >> - Rename EXCLUDE_FROM_STATIC_LIBS to ONLY_EXPORTED, $(MODULE)_JDK_LIBS to >> $(MODULE)_INCLUDED_LIBS and module-libs.txt to module-included-libs.txt >> - Find LIBZIP_OBJS automatically >> - Find LIBJAVA_JPEG_OBJS automatically >> - Just exclude the a11y libraries from static builds >> - Copy debuginfo >> - Restore SetExecname in java_md.c >> - Fix incremental builds >> - Merge branch 'master' into static-jdk-image >> - ... and 15 more: https://git.openjdk.org/jdk/compare/c329f97f...8b1217a8 > > src/hotspot/os/linux/os_linux.cpp line 590: > >> 588: >> 589: // Found the full path to the binary. It is normally of this >> structure: >> 590: // <jdk_path>/lib/<hotspot_variant>/libjvm.so > > You could change <hotspot_variant> to server I believe, since there isn't a > client (I hope) version anymore. Variant can also be e.g. `minimal`. And I do think the client variant is still supported, even if it is not actively built..? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1866028280
