On Wed, 27 Nov 2024 20:34:21 GMT, Alisen Chung <[email protected]> wrote:
>> Test intermittently fails with a few different Exceptions. Initial report >> shows `Choice can't be controlled by keyboard` when failing. An additional >> report of an intermittent failure shows `Button does not have focus`. >> >> Added some stability fixes. Additional delays, removed extraneous window, >> and added an additional focus check. >> >> Debugged using additional screenshots during different failure points. Looks >> like sometimes the focus is still on the button. So, the delay has been >> added afterwards. Test passes on 22.04 Ubuntu machine with 100 repeats in >> CI. Also passed testing on all OS's with 50 repeats in CI. > > test/jdk/java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java line 49: > >> 47: * @key headful >> 48: * @summary Tests that Choice can be accessed and controlled by keyboard. >> 49: */ > > not sure if this is important but test doesn't have an @run tag which might > be good to include @alisenchung `@run` tag is not necessary for automated tests (unless you need to specific other options or run in othervm mode). If the `@run` tag is not specified jtreg runs the main method of the test class by default. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22333#discussion_r1861229365
