On Mon, 2 Dec 2024 17:42:21 GMT, Damon Nguyen <[email protected]> wrote:

>> Test intermittently fails with a few different Exceptions. Initial report 
>> shows `Choice can't be controlled by keyboard` when failing. An additional 
>> report of an intermittent failure shows `Button does not have focus`.
>> 
>> Added some stability fixes. Additional delays, removed extraneous window, 
>> and added an additional focus check.
>> 
>> Debugged using additional screenshots during different failure points. Looks 
>> like sometimes the focus is still on the button. So, the delay has been 
>> added afterwards. Test passes on 22.04 Ubuntu machine with 100 repeats in 
>> CI. Also passed testing on all OS's with 50 repeats in CI.
>
> Damon Nguyen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Amend test

LGTM, test works as expected on different platforms.

-------------

Marked as reviewed by abhiscxk (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22333#pullrequestreview-2475401257

Reply via email to