On Tue, 26 Nov 2024 23:23:59 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Daniel Gredler has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add additional issue ID to PrintTextTest bug list > > src/java.desktop/share/classes/sun/print/PathGraphics.java line 962: > >> 960: } >> 961: } >> 962: > > The fix to PathGraphics.java looks good. > > A new font var is used to copy over all the transforms except translation > from the original font object and use new font reference in drawString(). The > translation transform is skipped since the drawString takes care of x and y > positions. That's right, this avoids doubling of the text start position coordinates, since the glyph positions which we are about to use already include this translation component. Let me know if you see anything that should be changed, or if I can mark this conversation as resolved. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21980#discussion_r1863810425
