On Sun, 17 Nov 2024 06:50:30 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Since JEP 486 : Permanently Disable the Security Manager >> [https://bugs.openjdk.org/browse/JDK-8338625] is now integrated, calls to >> java.security.AccessController.doPrivileged are obsolete and can be removed. >> >> This PR takes care of the windows-platform files in the java.desktop module >> to have them removed. > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - Fix to getBoolean > - FIx Boolean.getBoolean src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java line 102: > 100: > 101: if (textLayoutStr != null) { > 102: useGDITextLayout = Boolean.getBoolean(textLayoutStr); Noticed a possible pre-existing bug: `Boolean::getBoolean` takes a system property to look up and evaluate to boolean. Here, this method is given a string which is the result of reading the system propery "sun.java2d.print.enableGDITextLayout". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1876820904