On Mon, 9 Dec 2024 21:57:35 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Fix to getBoolean
>> - FIx Boolean.getBoolean
>
> src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java line 102:
>
>> 100:
>> 101: if (textLayoutStr != null) {
>> 102: useGDITextLayout = Boolean.getBoolean(textLayoutStr);
>
> Noticed a possible pre-existing bug:
>
> `Boolean::getBoolean` takes a system property to look up and evaluate to
> boolean. Here, this method is given a string which is the result of reading
> the system propery "sun.java2d.print.enableGDITextLayout".
@eirbjo Thank you for submitting
[JDK-8345934](https://bugs.openjdk.org/browse/JDK-8345934).
[I found this
issue](https://github.com/openjdk/jdk/pull/22083#discussion_r1846889627) too,
yet it's marked as resolved… because it's out of scope for this change.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1888947742