On Fri, 3 Jan 2025 14:13:15 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> I wonder if such a customisation is supported. Synth and Nimbus don't always
> use the `UIMaganager` to set the defaults. Perhaps, these Look-and-Feels
> should be excluded from this test.
>
> On the other hand, Swing usually allows such customisations and respects
> settings in `UIManger`… but doing so in Synth and Nimbus often looks
> inconsistent and requires special handling of UI-delegate classes.
I thought about ignoring this property for Synth and probably close "Not an
issue" but I could not find in spec of not honoring UIManager properties in
Synth so added this fix...I guess we can argue for both for and against of
adding this support in Synth but since it's pretty early in jdk25 mainline so
any problem arising out of this can be tackled before the final release..
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthDefaultLookup.java
> line 44:
>
>> 42: if (value != null) {
>> 43: return value;
>> 44: }
>
> It should probably call `super.getDefault` rather than use `UIManager`
> directly.
ok..
> test/jdk/javax/swing/JOptionPane/bug4174551.java line 26:
>
>> 24: /*
>> 25: * @test
>> 26: * @bug 4174551 8346260
>
> Should the test exercise all available Look and Feels?
SInce it's manual test, I guess this will make it more complex..its good as it
is..
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22908#issuecomment-2569363281
PR Review Comment: https://git.openjdk.org/jdk/pull/22908#discussion_r1901867449
PR Review Comment: https://git.openjdk.org/jdk/pull/22908#discussion_r1901867980
