On Mon, 6 Jan 2025 06:15:37 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Abhishek Kumar has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8339728 >> - Copyright year and minor fix >> - Review comment update >> - Copyright year and test update >> - MenuItem shortcut accessibility fix > > src/jdk.accessibility/windows/native/include/bridge/AccessBridgePackages.h > line 2: > >> 1: /* >> 2: * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights >> reserved. > > this copyright also needs to be updated.. Updated. > test/jdk/javax/accessibility/TestJMenuItemShortcutAccessibility.java line 49: > >> 47: 3. Navigate the Menu Items by using UP / DOWN arrow key >> 48: 4. Press Pass if you are able to hear correct JAWS >> announcements >> 49: for each menu item shortcut else Fail > > should we need not expand what is "correct" JAWS announcements? like > mentioning it should read aloud "full" shortcut text and not only the 1st > character of shortcut Updated test instruction. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1903752040 PR Review Comment: https://git.openjdk.org/jdk/pull/22822#discussion_r1903752306
