On Mon, 6 Jan 2025 07:09:23 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>> For a JMenuItem with a shortcut like _Ctrl + Comma_, the `getKeyChar` method 
>> of the `AccessBridge` class cuts the _Comma_ text to the first character and 
>> hence transfers `C (instead of Comma)` via the `AccessBridge` API. For a 
>> shortcut _Ctrl + Comma_ in a menu item, screen readers announce _Ctrl + C_ 
>> instead of _Ctrl + Comma_ as shortcut. Same issue exists for **Enter, Period 
>> and other keys** as well where only the first character is returned from the 
>> getKeyChar method. 
>> 
>> Proposed fix is to ensure that the _char representation of the shortcuts_ is 
>> returned by the `getKeyChar` method and it worked fine except for 
>> **"Enter"** key. It is unclear to me why it has not announced by AT (JAWS) 
>> but I think that may be due to the char representation of the Enter key 
>> which is a Line Feed.
>> 
>> AT was also not able to announce the _Tab and Space_ key as a shortcut. 
>> Adding these keys in the control key list in _AccessBridge_ and in supported 
>> control code list in _AccessBridgePackages_ files enabled them to be 
>> announced by AT.
>> 
>> Manual test case is added to verify the shortcut for JMenuItems.
>
> Abhishek Kumar has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Instruction and missed copyright year update

> > …it worked fine except for Enter key…
> 
> Should we submit a bug? It's _a known problem_ now, but there's no fix for 
> it. It could be a limitation that may be worth calling out in a release note.

Yeah, as of now I don't have a fix for "Enter" key shortcut or it may be a 
limitation.
I am not sure if filing a bug is a good idea as it may just increase the 
backlog with no potential solution.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22822#issuecomment-2574683102

Reply via email to