On Thu, 12 Dec 2024 16:01:18 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> **Description:** >> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media >> imageable area values according to the PostScript Printer Description File >> Format Specification. >> The actual implementation reads X and Y coordinates of the upper right >> corner of the imageable area as width and height of the imageable area. >> https://bugs.openjdk.org/browse/JDK-8344119 >> >> **Updates:** >> Added subtraction of the X and Y coordinates of the lower left corner to fix >> the width and height values of the imageable area. >> >> **Tests:** >> Tested with `test/jdk/javax/print/DialogMargins.java` using Brother >> DCP-T720DW, the test draws a black line along the borders of the imageable >> area. >> The test was run with the minimum possible margins. >> _Before the fix_: the right and bottom lines are not printed (the right and >> bottom lines are outside the printable area). >> _After the fix_: all lines are printed. > > So, how returning the correct values from JNI violate this? Even if we do the > calculation in the native, we will still be returning float values for upper > top, right coordinates, correct? @prsadhuk, I moved changes to the CUPSfuncs.c. Could you please take a look? ------------- PR Comment: https://git.openjdk.org/jdk/pull/22110#issuecomment-2586876910
