On Tue, 21 Jan 2025 03:35:30 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> GennadiyKrivoshein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove trailing whitespace
>
> test/jdk/javax/print/CUPSPrinterImageableAreaTest.java line 121:
>
>> 119: job.setPrintable(new RectPrintable(), pageFormat);
>> 120: try {
>> 121: job.print();
>
> it now goes to default printer..maybe also give an option to show a
> printdialog and let user choose the printer..I guess choosing PDF-printer
> will not show the issue?
I updated the test. The test does not use common print dialog to prevent
changes of the media and margins, and filtered out printers that do not have
phisycal margins (borderless).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22110#discussion_r1925247236