On Thu, 23 Jan 2025 20:31:03 GMT, Phil Race <p...@openjdk.org> wrote:
> The compiler must have been confused. Definitely, but I don't blame it. Look at this construct: #define IMGEXTERN #include "imageInitIDs.h" There is really no way for the poor compiler to understand that in this case, it was really intentional to define variables in a .h file. And once again, this is a clever construct. If we had used it in all our code base I would not have complained. But when we do it in just a single place, it breaks expectations, and it is better to align the code to how we do everywhere else. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23236#issuecomment-2611199045
