On Thu, 23 Jan 2025 20:31:03 GMT, Phil Race <p...@openjdk.org> wrote:
>> Joachim Kern has updated the pull request incrementally with one additional >> commit since the last revision: >> >> remove old solution > > If absolutely nothing else needs fp_pipewire.h I guess that ought to be OK > ... but this is very new code. > I'd like @azvegint to look at this as he may have had some reason that isn't > obvious. > > I don't follow why you found it necessary to remove the include statement > from the .c file in the image case ? > And I agree that there was actually nothing wrong with the existing code. The > compiler must have been confused. > > And other than *building* what testing was done with these changes ? @prrace Is this OK for you now after Aleksandr has tested and approved the PR? ------------- PR Comment: https://git.openjdk.org/jdk/pull/23236#issuecomment-2612112103
