On Tue, 28 Jan 2025 13:32:56 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
> In the makefile we reset LIBFONTMANAGER optimization, but is always set to > HIGHEST so we can avoid the resetting. Thanks for the reviews ! > Not all libraries do especially performance critical things. Agree, it was not my suggestion to set everywhere HIGH/HIGHEST . The question I had is - are there libraries where we set LOW because higher/other opt-levels would break the library (compilation and also runtime - wise) ? For most of the libs probably other opt levels would work too, but it is hard to say in general. Other question - for hotspot / libjvm we have the option to influence the opt - level we want to use in the build, e.g. by setting jvm feature opt-size and als link-time-optimization . As far as I know we do not have this yet for JDK native libs. I would like to have it at least for libs where it is possible and does not break anything (probably some opt-in parameter of the make rule of the lib ). ------------- PR Comment: https://git.openjdk.org/jdk/pull/23332#issuecomment-2620965972
