On Thu, 30 Jan 2025 08:51:05 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radiobutton is drawn. Added provision of drawing >> the radiobutton windows Skin even when imageIcon is present. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > image path correction src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java line 881: > 879: skin.paintSkin(g, x + OFFSET, y + > OFFSET, state); > 880: } else { > 881: skin = xp.getSkin(c, part); `skin = xp.getSkin(c, part);` can be taken out of if-else block. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935299374