On Thu, 30 Jan 2025 11:40:30 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> optimise > > src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java > line 891: > >> 889: Part part; >> 890: if (type == JRadioButtonMenuItem.class) { >> 891: part = Part.BP_RADIOBUTTON; > > The part `Part.BP_RADIOBUTTON` doesn't look right to me. > > The selected case above always uses the part `Part.MP_POPUPCHECK` — and it > looks correct because this code paints a menu item (and radio or check menu > items are usually in popup menus rather than on the menu bar). You are right..It is not needed..I have removed.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935552863