On Tue, 4 Feb 2025 11:23:52 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>>> This is why we should re-work the layout of menus with icons if there's any 
>>> radio- or check-menu item as I [suggested 
>>> above](https://github.com/openjdk/jdk/pull/23324#discussion_r1935784688).
>> 
>> Not sure I understand...As in windows11 Explorer, radiobutton checkmark and 
>> icon are at the same position as in jdk..
>> what more you are suggesting to change?
>
> Radio- or checks are in the same position but ***the icon itself** is moved 
> to the right* so that both the bullet or check and the icon are displayed.
> 
> Currently, only the icon is rendered at the place where the bullet or 
> checkmark are if there's no icon.
> 
> The result should like this
> 
> ![Proposed layout for icons and 
> bullets](https://github.com/user-attachments/assets/c3809aaa-3219-4b9a-b86e-7850a747f652)
> 
> instead of
> 
> ![Windows 10 - red square item 
> selected](https://github.com/user-attachments/assets/343adf20-b3ca-4c06-af93-e63736bce123)
> 
> It is the former image that corresponds to File Explorer in Windows 11: 
> https://github.com/openjdk/jdk/pull/23324#discussion_r1935744523

But that's what I believe is been done now in the PR test, corresponding to 
your 1st image and corresponds to windows11

![image](https://github.com/user-attachments/assets/2ddab37a-0513-4e08-8df9-9a3a2a054b8b)

If icon is present, it will be drawn at x+3*OFFSET...and button/checkmark is 
always drawn at x-OFFSET irrespective of icon
 present or not..
Are you suggesting to keep more gap in between checkmark and button?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1941010595

Reply via email to