On Thu, 30 Jan 2025 15:47:26 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is
>> shown without radiobutton in WIndowsLookAndFeel as there was no provision of
>> drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing
>> the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Draw checkmark skin at same location with/without icon
src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
line 884:
> 882: }
> 883: if (icon != null) {
> 884: icon.paintIcon(c, g, x + 3 * OFFSET, y + OFFSET);
Why offset is multiplied by 3? does it depend on the icon size?
Buffered Image in test code is of size 16x16. Is it possible that the icon can
be of different size?
If Icon size is more then I guess it may overlap with radio button skin.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1940864685
