On Tue, 11 Feb 2025 14:59:26 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> It is just checking for current L&F is Windows or not..I am not even >> checking for "instanceof WIndowsLookAndFeel" which will not be present in >> linux and mac so I dont think it will create any problem.. >> Helper method will create unnecessary changes in all L&F..I dont think I >> will like to do that.. > > It just feels wrong… A superclass doesn't need to know, shouldn't know, about > its subclasses. > > Yet this solution could be the simplest one… if achieving the same effect > different makes the code too complicated. Where it is checking for subclasses? It is just checking for if the current lookandfeel is Windows L&F (as I told it is not checking for `instanceof WindowsLookAndFeel` in which case one could have argued that it is trying to know about windows subclass.. Also, having helper method will have effect in only Windows subclass and noop in others and that is unnecessary in my opinion and on top of that, it will need a CSR for that method and that method would be additional maintenance headache and it will prevent backporting this fix if one wants to and considering this is related to JCK issue, people would like it to be backported.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1951912770
