On Fri, 7 Feb 2025 05:26:10 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is >> shown without radiobutton in WIndowsLookAndFeel as there was no provision of >> drawing the radiobutton alongside icon. >> If icon is not there, the radiobutton is drawn. Added provision of drawing >> the radiobutton windows Skin even when imageIcon is present. > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - remove test file > - Move text position w.r.t menuItem icon > This is how it looks on Windows 10: >  > > It's close, yet the spacing is wrong. > > The bullet / check-mark should be where they were before the fix. There was > 8-pixel margin to the left of selected bullet background before the fix, now > there are only 2 pixels. > > The margin between the bullet background and the text was again 8 pixels, I > think we should maintain the same margin between the bullet and the icon as > well as between the icon and the menu text. Does bullet/checkmark use to appear before the fix in windows 10? I thought you told the icon was getting highlighted/dehighlighted depending on item is selected or not I am not sure if we can make 8 pixel margin as it will cause MenuItem text or bullet to be outgrow popmenu width ( I faced this issue while experimenting with spacing), which I am not sure if and where we can increase. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2646955190
