On Wed, 12 Feb 2025 14:32:04 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Ending support shouldn't mean we should make Windows 10 design look like
>> Windows 11, that would be so wrong, in my opinion..because the user would
>> like to get the same look and feel as in native Windows 10 as much as
>> possible..
>
>> Ending support shouldn't mean we should make Windows 10 design look like
>> Windows 11, that would be so wrong, in my opinion..because the user would
>> like to get the same look and feel as in native Windows 10 as much as
>> possible..
>
> The thing is neither of us has found any app which displays both radio
> bullets or check-marks and an icon in its menus.
>
> The problem with `.equals("Windows 11")` is that it'll need updating if and
> when Microsoft releases a newer version of Windows because Windows 12 will
> fallback to rendering like in Windows 10 and earlier versions.
Is it mentioned somewhere that Windows 12 will fallback to Windows 10
rendering? Usually, newer version will carry forward previous design i.e
Windows 11 or create entire new design
I guess we will cross that bridge when it comes.
For now, I think this is the least-intrusive, no-CSR-required fix that
preserves Windows 10 design and honor Windows 11 native layout as much as
possible.
You can propose a better solution, if you have, but till then I think we should
allow it.
Let's hear from other Reviewers..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1953731346
