On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy <d...@openjdk.org> wrote: >> This adds support for parsing thumbnails in an APP1 Exif marker. >> >> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In >> that previous work the only additional meta info he parsed was the image >> creation time; this PR similarly includes the same property. (I can't speak >> to why he included that property, but it looks like he has a lot of >> experience with ImageIO so I trust his judgment.) >> >> The test addresses the original images attached to the ticket plus a few >> extra images I found on my computer that include unusual properties. >> (Possibly those images are malformed, but if they exist in the wild and >> other platforms support them then I'd prefer to support them too.) > > Jeremy has updated the pull request incrementally with one additional commit > since the last revision: > > 8160327: fixing typo so `thumbnailPos` can be zero > > The `thumbnailLength` cannot be zero, but the position can be.
Yes: the new 3 images are images that I own (plastic-wrap, unusual-IFD, bad-timestamp). Brian just confirmed we can use SV650. Sometime (maybe this weekend?) I can scan all the JPEGs on my machine and see if I find one with properties that match other 2 jpeg files we may not have permission to share (exif-rgb-thumbnail, sharpshot-iphone). (I'll also review PR's other notes.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/22898#issuecomment-2657909448
