On Thu, 2 Jan 2025 06:49:19 GMT, Jeremy <d...@openjdk.org> wrote:
>> This adds support for parsing thumbnails in an APP1 Exif marker.
>>
>> This builds on an unfinished proposal by Brian Burkhalter (around 2016). In
>> that previous work the only additional meta info he parsed was the image
>> creation time; this PR similarly includes the same property. (I can't speak
>> to why he included that property, but it looks like he has a lot of
>> experience with ImageIO so I trust his judgment.)
>>
>> The test addresses the original images attached to the ticket plus a few
>> extra images I found on my computer that include unusual properties.
>> (Possibly those images are malformed, but if they exist in the wild and
>> other platforms support them then I'd prefer to support them too.)
>
> Jeremy has updated the pull request incrementally with one additional commit
> since the last revision:
>
> 8160327: fixing typo so `thumbnailPos` can be zero
>
> The `thumbnailLength` cannot be zero, but the position can be.
src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java
line 266:
> 264: && (buf[ptr+7] == 0)
> 265: && (buf[ptr+8] == 0)) {
> 266: newGuy = new ExifMarkerSegment(buffer);
The `IllegalArgumentException` from the `ExifMarkerSegment` constructor should
be handled somehow. Perhaps just fall back to setting `newGuy` to a plain
`MarkerSegment`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22898#discussion_r1956751427
