On Thu, 13 Feb 2025 11:55:53 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Filed as a separate issue to keep the #23426 clean. >> >> Fix is the same as in the >> `src/java.desktop/unix/native/libpipewire/include/spa/param/audio/raw.h` >> part of the [JDK-8309703](https://bugs.openjdk.org/browse/JDK-8309703) > > Alexander Zvegintsev has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains seven commits: > > - Merge master > - move fix to spa/utils/endian.h > - merge "if defined" > - 8349751: AIX build failure after upgrade pipewire to 1.3.81 > - replace "\t" with " ", part 2 > - replace "\t" with " " > - 8348600: Update PipeWire to 1.3.81 FWIW (1) I do not like JDK changes in upstream files we import (2) This really needs to be done by the port owners. (3) I do not like JDK changes in upstream files we import Yes, I'm repeating that. We do have one case of changes which never made it into upstream in some X11 copied code from xwd because xwd is an app and doesn't care about resource leakage (ie there are upstream unfixed bugs). But I don't think we need to expand that precedent. This change needs to be up-streamed. I do not want the burden of 'remembering' this. Let's call this the last time we include this into JDK unless it comes from pipewire. ------------- PR Review: https://git.openjdk.org/jdk/pull/23543#pullrequestreview-2616757880
