On Fri, 14 Feb 2025 04:52:31 GMT, Phil Race <p...@openjdk.org> wrote:
>> Alexander Zvegintsev has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains seven commits: >> >> - Merge master >> - move fix to spa/utils/endian.h >> - merge "if defined" >> - 8349751: AIX build failure after upgrade pipewire to 1.3.81 >> - replace "\t" with " ", part 2 >> - replace "\t" with " " >> - 8348600: Update PipeWire to 1.3.81 > > FWIW > (1) I do not like JDK changes in upstream files we import > (2) This really needs to be done by the port owners. > (3) I do not like JDK changes in upstream files we import > Yes, I'm repeating that. We do have one case of changes which never made it > into upstream in some X11 copied code from xwd because xwd is an app and > doesn't care about resource leakage (ie there are upstream unfixed bugs). But > I don't think we need to expand that precedent. > This change needs to be up-streamed. I do not want the burden of > 'remembering' this. > Let's call this the last time we include this into JDK unless it comes from > pipewire. @prrace: I wonder if pipewire should be build on any platform other than linux. Is there any usage on other UNIX systems (AIX/BSD/...)? ------------- PR Comment: https://git.openjdk.org/jdk/pull/23543#issuecomment-2659766360
