On Mon, 24 Feb 2025 18:59:34 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   javadoc update
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 116:
> 
>> 114:      * BuiltInProfile.
>> 115:      */
>> 116:     private boolean isBuiltIn = false;
> 
> Should the field be named `builtIn` instead? `isBuiltIn` starts with a verb 
> which is used for naming methods.

IIRC we usually have `is` or `has` prefixed to boolean vars as per naming 
convention?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1968277681

Reply via email to