On Tue, 25 Feb 2025 10:57:38 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed flag to builtIn
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 115:
>
>> 113: * This check is used in {@link #setData(int, byte[])} to prevent
>> modifying
>> 114: * Built-in profiles.
>> 115: */
>
> /**
> * Set to {@code true} for {@code BuiltInProfile},
> * remains {@code false} otherwise.
> * This flag is used in {@link #setData(int, byte[])} to prevent modifying
> * built-in profiles.
> */
>
> There's no need to capitalise “Built-in”.
It's recommended to use `{@code}` for keywords, therefore both `true` and
`false` should be marked up with `{@code}`.
See [How to Write Doc Comments for the Javadoc Tool, A Style
Guide](https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html#styleguide):
> Use `<code>` style for keywords and names.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1979301473
