On Fri, 7 Mar 2025 21:36:03 GMT, Phil Race <p...@openjdk.org> wrote: >> GennadiyKrivoshein has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 15 commits: >> >> - Update copyright, fix typos, move the proxy to the macos >> - Merge branch 'master' into monochrome-printing >> - proxy mac only >> - Revert "grammar fixes" >> >> This reverts commit 355b2b8f1dbc71cef433e9a925dfb8a7fff56f99. >> - Revert "formatting" >> >> This reverts commit fde514baeadc2775fa502a2a2d312c6038880e7a. >> - Revert "update copyright" >> >> This reverts commit 60e9b4f024544cfac4ddaddc1ea3653bd4a2fe4c. >> - Revert "move grayscale methods to PSPathGraphics" >> >> This reverts commit 1ef135680645ad2647c4430e852095dda8aa7e0c. >> - Merge remote-tracking branch 'openjdk/master' into monochrome-printing >> >> # Conflicts: >> # src/java.desktop/share/classes/sun/print/RasterPrinterJob.java >> - Merge remote-tracking branch 'openjdk/master' into monochrome-printing >> - move grayscale methods to PSPathGraphics >> - ... and 5 more: https://git.openjdk.org/jdk/compare/6c591854...5486473b > > src/java.desktop/macosx/classes/sun/print/GrayscaleProxyGraphics2D.java line > 3: > >> 1: /* >> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved. >> 3: * Copyright (c) 2024, BELLSOFT. All rights reserved. > > I suggest updating everything to be 2025
This class *could* be useful in other cases besides macOS. So perhaps you can move it to share/classes/sun/print ? I note that macOS printing - unlike the Postscript and GDI cases - doesn't depend on the Banding raster print path. To use it elsewhere, if there's transparency, we'd need to do something similar there to translate the band to gray - but that should not be too hard, if we need it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21930#discussion_r1985767596
