On Fri, 7 Mar 2025 21:17:01 GMT, Phil Race <p...@openjdk.org> wrote:
>> GennadiyKrivoshein has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 15 commits:
>>
>> - Update copyright, fix typos, move the proxy to the macos
>> - Merge branch 'master' into monochrome-printing
>> - proxy mac only
>> - Revert "grammar fixes"
>>
>> This reverts commit 355b2b8f1dbc71cef433e9a925dfb8a7fff56f99.
>> - Revert "formatting"
>>
>> This reverts commit fde514baeadc2775fa502a2a2d312c6038880e7a.
>> - Revert "update copyright"
>>
>> This reverts commit 60e9b4f024544cfac4ddaddc1ea3653bd4a2fe4c.
>> - Revert "move grayscale methods to PSPathGraphics"
>>
>> This reverts commit 1ef135680645ad2647c4430e852095dda8aa7e0c.
>> - Merge remote-tracking branch 'openjdk/master' into monochrome-printing
>>
>> # Conflicts:
>> # src/java.desktop/share/classes/sun/print/RasterPrinterJob.java
>> - Merge remote-tracking branch 'openjdk/master' into monochrome-printing
>> - move grayscale methods to PSPathGraphics
>> - ... and 5 more: https://git.openjdk.org/jdk/compare/6c591854...5486473b
>
> test/jdk/javax/print/attribute/MonochromePrintTest.java line 63:
>
>> 61: * @key printer
>> 62: * @requires (os.family == "mac")
>> 63: * @summary javax.print: Support monochrome printing
>
> This needs to be marked as main/manual
>
> In addition you should use the PassFailJFrame framework you will see widely
> used in other manual tests that have been added or updated in the last year.
Updated to use PassFailJFrame, the test is manual.
> test/jdk/javax/print/attribute/MonochromePrintTest.java line 124:
>
>> 122: String[] instructions = {
>> 123: "Two tests will run and it will test all available
>> color apearances:",
>> 124: Arrays.toString(supportedChromaticity) + "supported by
>> the printer.",
>
> you need to add spaces around the toString(..). Currently this is displayed as
> "Two tests will run and it will test all available color apearances:[color,
> monochrome]supported by the printer"
Updated
> test/jdk/javax/print/attribute/MonochromePrintTest.java line 199:
>
>> 197: private static void print(Chromaticity chromaticity) throws
>> PrinterException {
>> 198: PrintRequestAttributeSet attr = new
>> HashPrintRequestAttributeSet();
>> 199: attr.add(MediaSizeName.ISO_A4);
>
> You should remove this line .. A4 is not necessarily available.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21930#discussion_r2007850190
PR Review Comment: https://git.openjdk.org/jdk/pull/21930#discussion_r2007853474
PR Review Comment: https://git.openjdk.org/jdk/pull/21930#discussion_r2007851119
