On Wed, 5 Mar 2025 22:07:05 GMT, Phil Race <p...@openjdk.org> wrote: >> GennadiyKrivoshein has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains five >> additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into print_options_idx_out_of_rng >> - remove code duplication >> - replace regexp s+ with space >> - use array for option args >> - Fix ArrayIndexOutOfBoundsException at PSPrinterJob printExecCmd > > I notice that UnixPrintJob is even worse .. it would have the same problem > except it doesn't even try to iterate over options, even though they can be > specified ! > > I think it makes sense to fix that too.
@prrace UnixPrintJob updated. I found only one way to test UnixPrintJob and validate lpr command arguments - parse debug output of the print service and compare expected and actual options. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23457#issuecomment-2710613725
